netdev - Re: [patch 03/18] drivers/net/ns83820.c: add paramter to disable autonegotiation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070810151818.df28b709.akpm@linux-foundation.org>
Date:	Fri, 10 Aug 2007 15:18:18 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Benjamin LaHaise <bcrl@...ck.org>
Cc:	jeff@...zik.org, netdev@...r.kernel.org, dan@...nnet.dk,
	dan@...ker.dk, jgarzik@...ox.com
Subject: Re: [patch 03/18] drivers/net/ns83820.c: add paramter to disable
 autonegotiation

On Fri, 10 Aug 2007 17:13:49 -0400
Benjamin LaHaise <bcrl@...ck.org> wrote:

> On Fri, Aug 10, 2007 at 02:05:13PM -0700, akpm@...ux-foundation.org wrote:
> > Also added a "disable_autoneg" module argument to completely disable
> > autoneg on all cards using this driver.
> ...
> > [akpm: this is a previously-nacked patch, but the problem is real]
> 
> Please remove this part of the patch.  The ethtool support is sufficient and 
> doesn't clobber other cards in the system.  At the very least the module 
> parameter has to be limited to a specific card.
> 

I think I'll drop the whole patch.  I've been nursing the thing along for
1.5 years and I don't recall seeing any reports of any bugs which it would
have fixed anyway.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html