netdev - Re: [patch 14/28] dccp: fix memory leak and clean up style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070810.152409.69410107.davem@davemloft.net>
Date:	Fri, 10 Aug 2007 15:24:09 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	akpm@...ux-foundation.org
Cc:	netdev@...r.kernel.org, jesper.juhl@...il.com,
	ian.mcdonald@...di.co.nz
Subject: Re: [patch 14/28] dccp: fix memory leak and clean up style -
 dccp_feat_empty_confirm()

From: akpm@...ux-foundation.org
Date: Fri, 10 Aug 2007 14:11:57 -0700

> From: Jesper Juhl <jesper.juhl@...il.com>
> 
> There's a memory leak in net/dccp/feat.c::dccp_feat_empty_confirm().  If we
> hit the 'default:' case of the 'switch' statement, then we return without
> freeing 'opt', thus leaking 'struct dccp_opt_pend' bytes.
> 
> The leak is fixed easily enough by adding a kfree(opt); before the return
> statement.
> 
> The patch also changes the layout of the 'switch' to be more in line with
> CodingStyle.
> 
> Signed-off-by: Jesper Juhl <jesper.juhl@...il.com>
> Acked-by: Ian McDonald <ian.mcdonald@...di.co.nz>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>

Applied to net-2.6, thanks!
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html