netdev - Re: [patch 24/28] netconsole: Introduce netconsole_netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070810.153313.24202743.davem@davemloft.net>
Date:	Fri, 10 Aug 2007 15:33:13 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	akpm@...ux-foundation.org
Cc:	netdev@...r.kernel.org, satyam@...radead.org,
	k-keiichi@...jp.nec.com, mpm@...enic.com
Subject: Re: [patch 24/28] netconsole: Introduce netconsole_netdev_notifier

From: akpm@...ux-foundation.org
Date: Fri, 10 Aug 2007 14:12:06 -0700

> From: Satyam Sharma <satyam@...radead.org>
> 
> Based upon initial work by Keiichi Kii <k-keiichi@...jp.nec.com>.
> 
> To update fields of underlying netpoll structure at runtime on corresponding
> NETDEV_CHANGEADDR or NETDEV_CHANGENAME notifications.
> 
> ioctl(SIOCSIFHWADDR or SIOCSIFNAME) could be used to change the hardware/MAC
> address or name of the local interface that our netpoll is attached to. 
> Whenever this happens, netdev notifier chain is called out with the
> NETDEV_CHANGEADDR or NETDEV_CHANGENAME event message.  We respond to that and
> update the local_mac or dev_name field of the struct netpoll.  This makes
> sense anyway, but is especially required for dynamic netconsole because the
> netpoll structure's internal members become user visible files when either
> sysfs or configfs are used.  So this helps us to keep up with the MAC
> address/name changes and keep values in struct netpoll uptodate.
> 
> [ Note that ioctl(SIOCSIFADDR) to change IP address of interface at
>   runtime is not handled (to update local_ip of netpoll) on purpose --
>   some setups may set the local_ip to a private address, not necessary
>   the actual IP address of the sender host, as presently allowed. ]
> 
> Signed-off-by: Satyam Sharma <satyam@...radead.org>
> Signed-off-by: Keiichi Kii <k-keiichi@...jp.nec.com>
> Cc: Matt Mackall <mpm@...enic.com>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>

Applied to net-2.6.24, thanks!
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html