netdev - Re: [NET]: Share correct feature code between bridging and bonding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070810.154817.04442540.davem@davemloft.net>
Date:	Fri, 10 Aug 2007 15:48:17 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	netdev@...r.kernel.org
Subject: Re: [NET]: Share correct feature code between bridging and bonding

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Thu, 9 Aug 2007 11:36:01 +0800

> Hi Dave:
> 
> [NET]: Share correct feature code between bridging and bonding
> 
> http://bugzilla.kernel.org/show_bug.cgi?id=8797 shows that the
> bonding driver may produce bogus combinations of the checksum
> flags and SG/TSO.
> 
> For example, if you bond devices with NETIF_F_HW_CSUM and
> NETIF_F_IP_CSUM you'll end up with a bonding device that
> has neither flag set.  If both have TSO then this produces
> an illegal combination.
> 
> The bridge device on the other hand has the correct code to
> deal with this.
> 
> In fact, the same code can be used for both.  So this patch
> moves that logic into net/core/dev.c and uses it for both
> bonding and bridging.
> 
> In the process I've made small adjustments such as only
> setting GSO_ROBUST if at least one constituent device
> supports it.
> 
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Applied, thanks a lot for fixing this bug Herbert!
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html