netdev - Re: [PATCH] net/tulip/xircom_cb.c: remove superfulous priv assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46C13822.7040803@pobox.com>
Date:	Tue, 14 Aug 2007 01:05:38 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Mariusz Kozlowski <m.kozlowski@...land.pl>
CC:	Arjan van de Ven <arjan@...radead.org>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/tulip/xircom_cb.c: remove superfulous priv assignment

Mariusz Kozlowski wrote:
> Hello,
> 
> 	Unpatched version does sth like this:
> 
> dev = alloc_etherdev(...
> private = netdev_priv(dev);
> ...
> dev->priv = private;
> 
> which doesn't make much sense (does it?) because this is done in
> alloc_netdev() already.
> 
> struct net_device *alloc_netdev(...
> {
> ...
> 	if (sizeof_priv)
> 		dev->priv = netdev_priv(dev);
> 
> This patch removes superfluous code.
> 
> Signed-off-by: Mariusz Kozlowski <m.kozlowski@...land.pl>

applied


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html