netdev - Re: [PATCH 2/6] e1000e: remove namespace collisions with e1000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46C139F6.2040007@garzik.org>
Date:	Tue, 14 Aug 2007 01:13:26 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Auke Kok <auke-jan.h.kok@...el.com>
CC:	netdev@...r.kernel.org, akpm@...ux-foundation.org,
	andi@...stfloor.org
Subject: Re: [PATCH 2/6] e1000e: remove namespace collisions with e1000

Auke Kok wrote:
> To prevent future collisions we rename all extern's from e1000_
> to e1000e_*. The list of changed symbols was taken from e1000.h
> Compile tested with CONFIG_E1000=y and CONFIG_E1000E=y.
> 
> Signed-off-by: Auke Kok <auke-jan.h.kok@...el.com>
> ---
> 
>  drivers/net/e1000e/82571.c   |  129 +++++++++++++-------------
>  drivers/net/e1000e/e1000.h   |  194 +++++++++++++++++++--------------------
>  drivers/net/e1000e/es2lan.c  |  118 ++++++++++++------------
>  drivers/net/e1000e/ethtool.c |   62 ++++++------
>  drivers/net/e1000e/ich8lan.c |   92 +++++++++---------
>  drivers/net/e1000e/lib.c     |  210 +++++++++++++++++++++---------------------
>  drivers/net/e1000e/netdev.c  |  168 +++++++++++++++++-----------------
>  drivers/net/e1000e/param.c   |    8 +-
>  drivers/net/e1000e/phy.c     |  138 ++++++++++++++--------------
>  9 files changed, 559 insertions(+), 560 deletions(-)

if you grep around this effort was already started using the 'e1e_' 
prefix.  I like the shorter prefix, but your call ultimately.  Either 
way, make sure to make the driver consistent there too.

e1e_flush(), e1e_wphy(), etc.

Overall I still want to push the driver towards shorter function and 
variable names.  Things like
e1000e_get_speed_and_duplex_fiber_serdes are just way too long.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html