netdev - Re: [patch 06/18] PCI-X/PCI-Express read control interfaces: use them in myrinet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46C13DE5.2070107@garzik.org>
Date:	Tue, 14 Aug 2007 01:30:13 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	akpm@...ux-foundation.org, brice@...i.com
CC:	netdev@...r.kernel.org, peter.oruba@....com, rolandd@...co.com,
	shemminger@...ux-foundation.org
Subject: Re: [patch 06/18] PCI-X/PCI-Express read control interfaces: use
 them in myrinet

akpm@...ux-foundation.org wrote:
> From: "Peter Oruba" <peter.oruba@....com>
> 
> These driver changes incorporate the proposed PCI-X / PCI-Express read byte
> count interface.  Reading and setting those valuse doesn't take place
> "manually", instead wrapping functions are called to allow quirks for some
> PCI bridges.
> 
> Signed-off by: Peter Oruba <peter.oruba@....com>
> Based on work by Stephen Hemminger <shemminger@...ux-foundation.org>
> Cc: Roland Dreier <rolandd@...co.com>
> Cc: Brice Goglin <brice@...i.com>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> ---
> 
>  drivers/net/myri10ge/myri10ge.c |    3 +--
>  1 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff -puN drivers/net/myri10ge/myri10ge.c~pci-x-pci-express-read-control-interfaces-myrinet drivers/net/myri10ge/myri10ge.c
> --- a/drivers/net/myri10ge/myri10ge.c~pci-x-pci-express-read-control-interfaces-myrinet
> +++ a/drivers/net/myri10ge/myri10ge.c
> @@ -2884,8 +2884,7 @@ static int myri10ge_probe(struct pci_dev
>  			status);
>  		goto abort_with_netdev;
>  	}
> -	val = (val & ~PCI_EXP_DEVCTL_READRQ) | (5 << 12);
> -	status = pci_write_config_word(pdev, cap + PCI_EXP_DEVCTL, val);
> +	status = pcie_set_readrq(pdev, 4096);


I presume Brice will resend this one to me, next time he pushes...

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html