netdev - [PATCH] netfilter : xt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070814142024.56af05b2.dada1@cosmosbay.com>
Date:	Tue, 14 Aug 2007 14:20:24 +0200
From:	Eric Dumazet <dada1@...mosbay.com>
To:	"kaber@...sh.net" <kaber@...sh.net>,
	David Miller <davem@...emloft.net>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, jengelh@....de
Subject: [PATCH] netfilter : xt_u32 bug correction

Hi all

This applies to net-2.6 (so should be forwared to Linus for 2.6.23 inclusion ?)
Sorry for the first mail without attachment.

Thank you

[PATCH] netfilter : xt_u32 bug correction

An extraneous ";" makes xt_u32 match useless

Signed-off-by: Eric Dumazet <dada1@...mosbay.com>

diff --git a/net/netfilter/xt_u32.c b/net/netfilter/xt_u32.c
index 04b677a..89b2d5c 100644
--- a/net/netfilter/xt_u32.c
+++ b/net/netfilter/xt_u32.c
@@ -35,7 +35,7 @@ static bool u32_match_it(const struct xt_u32 *data,
 		at  = 0;
 		pos = ct->location[0].number;
 
-		if (skb->len < 4 || pos > skb->len - 4);
+		if (skb->len < 4 || pos > skb->len - 4)
 			return false;
 
 		ret   = skb_copy_bits(skb, pos, &val, sizeof(val));
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html