netdev - Re: [patch 12/18] e1000: #if 0 two functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46C21C09.30802@intel.com>
Date:	Tue, 14 Aug 2007 14:18:01 -0700
From:	"Kok, Auke" <auke-jan.h.kok@...el.com>
To:	Jeff Garzik <jeff@...zik.org>
CC:	akpm@...ux-foundation.org, netdev@...r.kernel.org, bunk@...sta.de
Subject: Re: [patch 12/18] e1000: #if 0 two functions

Kok, Auke wrote:
> Jeff Garzik wrote:
>> akpm@...ux-foundation.org wrote:
>>> From: Adrian Bunk <bunk@...sta.de>
>>>
>>> e1000_{read,write}_pci_cfg() are no longer used.
>>>
>>> Signed-off-by: Adrian Bunk <bunk@...sta.de>
>>> Cc: Auke Kok <auke-jan.h.kok@...el.com>
>>> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
>>> ---
>>>
>>>  drivers/net/e1000/e1000_hw.h   |    2 --
>>>  drivers/net/e1000/e1000_main.c |    4 ++++
>>>  2 files changed, 4 insertions(+), 2 deletions(-)
>> if it's truly dead code in upstream, we should just remove it from e1000
> 
> if I apply this to #master and compile, it blows up: the two functions are still 
> in use there. I also don't see any difference with current #upstream....
> 
> so, I don't know what is in -mm at the moment, but we do not want this in jeff's 
> tree.

whoops, I fail to correlate this with the mmrbc patch I just acked 5 minutes 
ago, which removes the need for these functions.

I'll push a patch to remove these functions once I hear what the plan is for the 
mmrbc patch.

Cheers,

Auke
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html