netdev - [PATCH 1/1] ipv6: corrects sended rtnetlink message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070815143322.GA25640@wq.cz>
Date:	Wed, 15 Aug 2007 16:33:22 +0200
From:	Milan Kocian <milon@...cz>
To:	netdev@...r.kernel.org
Subject: [PATCH 1/1] ipv6: corrects sended rtnetlink message

ipv6 sends a RTM_DELLINK netlink message on both events: NETDEV_DOWN,
NETDEV_UNREGISTER. Corrected by sending RTM_NEWLINK on NETDEV_DOWN event
and RTM_DELLINK on NETDEV_UNREGISTER event.
---

btw. I don't know why protocol sends a NL messages about iface state
changes. It comes from other sources. By contrast ipv6 doesn't send
no message on NETDEV_UP event !? IMO best possibility is deletion of
sending this message.


--- a/net/ipv6/addrconf.c	2007-08-13 11:35:23.481430029 +0200
+++ b/net/ipv6/addrconf.c	2007-08-13 12:47:01.825690662 +0200
@@ -2488,7 +2488,10 @@ static int addrconf_ifdown(struct net_de
 
 	/* Step 5: netlink notification of this interface */
 	idev->tstamp = jiffies;
-	inet6_ifinfo_notify(RTM_DELLINK, idev);
+	if (how)
+		inet6_ifinfo_notify(RTM_DELLINK, idev);
+	else 
+		inet6_ifinfo_notify(RTM_NEWLINK, idev);
 
 	/* Shot the device (if unregistered) */
 

Signed-off-by: Milan Kocian <milon@...cz>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html