netdev - Re: [RFC] restore netdev_priv optimization (planb)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070817182807.7591878d@freepuppy.rosehill.hemminger.net>
Date:	Fri, 17 Aug 2007 18:28:07 -0700
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	"Kok, Auke" <auke-jan.h.kok@...el.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [RFC] restore netdev_priv optimization (planb)

On Fri, 17 Aug 2007 18:21:25 -0700
"Kok, Auke" <auke-jan.h.kok@...el.com> wrote:

> David Miller wrote:
> > From: Stephen Hemminger <shemminger@...ux-foundation.org>
> > Date: Fri, 17 Aug 2007 17:49:09 -0700
> > 
> >> Fix optimization of netdev_priv() lost by the addition of multiqueue.
> >>
> >> Only configurations that define MULITQUEUE need the extra overhead in
> >> netdevice structure and the loss of the netdev_priv optimization.
> >>
> >> Signed-off-by: Stephen Hemminger <shemminger@...ux-foundation.org>
> > 
> > Every distribution vendor is going to turn MULTIQUEUE on.  Therefore
> > %99 of Linux users will not see any gain from your patch.
> > 
> > You're walking around in a dark room and hitting walls every
> > few seconds.  Take a moment and think about how to really deal
> > with this generically for a second before churning out another
> > patch.
> > 
> > For example, how about making the multiqueue limit fixed, say at 64
> > queues, and declare the egress_queues as an array of 64 entries.  Then
> > you can get constant pointer formation for both the netdev priv and
> > the queues.
> 
> this sounds highly optimistic ("64 queues is enough for everyone"?) and probably 
> will be quickly outdated by both hardware and demand...
> 

Plan C was replacing MULTIQUEUE boolean with a int value 1 ... 256.
All this was a one day "what if" exercise, not really a big churn..

-- 
Stephen Hemminger <shemminger@...ux-foundation.org>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html