lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 18 Aug 2007 11:15:25 -0700 From: Randy Dunlap <randy.dunlap@...cle.com> To: Jiri Slaby <jirislaby@...il.com> CC: Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org, source@...sta.com, dougthompson@...ssion.com, bluesmoke-devel@...ts.sourceforge.net, dtor@...l.ru, linux-input@...ey.karlin.mff.cuni.cz, netdev@...r.kernel.org, James.Bottomley@...elEye.com, linux-scsi@...r.kernel.org, gtolstolytkin@...mvista.com, vitalywool@...il.com, dsaxena@...xity.net, ralf@...ux-mips.org, linux-mips@...ux-mips.org, mchehab@...radead.org, video4linux-list@...hat.com, jbenc@...e.cz, flamingice@...rmilk.net, linux-wireless@...r.kernel.org Subject: Re: [PATCH 8/9] define global BIT macro Jiri Slaby wrote: > Randy Dunlap napsal(a): >> On Sat, 18 Aug 2007 11:44:12 +0200 (CEST) Jiri Slaby wrote: >> >>> define global BIT macro >>> >>> move all local BIT defines to the new globally define macro. >>> >>> Signed-off-by: Jiri Slaby <jirislaby@...il.com> >>> >>> --- >>> >>> include/linux/bitops.h | 1 + >>> include/video/sstfb.h | 1 - >>> include/video/tdfx.h | 2 -- >>> net/mac80211/ieee80211_i.h | 2 -- >>> 18 files changed, 1 insertions(+), 37 deletions(-) >>> >>> diff --git a/include/linux/bitops.h b/include/linux/bitops.h >>> index 3255b06..a57b81f 100644 >>> --- a/include/linux/bitops.h >>> +++ b/include/linux/bitops.h >>> @@ -3,6 +3,7 @@ >>> #include <asm/types.h> >>> >>> #ifdef __KERNEL__ >>> +#define BIT(nr) (1UL << (nr)) >>> #define BIT_MASK(nr) (1UL << ((nr) % BITS_PER_LONG)) >>> #define BIT_WORD(nr) ((nr) / BITS_PER_LONG) >>> #define BITS_TO_TYPE(nr, t) (((nr)+(t)-1)/(t)) >> >> So users of the BIT() macro in include/linux/input.h can be >> changed to use the global BIT_MASK() macro... >> and the former can be removed. > > I'm afraid I don't understand you. Maybe, you are writing about changes done in > patch no. 7 [1], which didn't go through to the lkml? > > [1] > http://www.fi.muni.cz/~xslaby/sklad/07-get-rid-of-input-bit-duplicate-defines.patch Exactly. Thanks. -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists