lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Aug 2007 13:51:37 +0200 From: Benjamin Thery <benjamin.thery@...l.net> To: David Miller <davem@...emloft.net> Cc: shemminger@...ux-foundation.org, netdev@...r.kernel.org, ebiederm@...ssion.com Subject: Re: [RFC] restore netdev_priv optimization Hi, David Miller wrote: > From: Stephen Hemminger <shemminger@...ux-foundation.org> > Date: Fri, 17 Aug 2007 15:40:22 -0700 > >> Compile tested only!!! > > Obviously. The first loopback transmit is guarenteed to crash. > > [...] > > And this also breaks loopback again, which uses a static struct netdev > in the kernel image, it doesn't use alloc_netdev(), so egress_subqueue > of loopback will be NULL. Talking about loopback, don't you think it could be the right time to make it behave like any other kind of net devices, and allocate it dynamically. Having a dynamically allocated loopback could make maintenance easier (removing special cases). Also this is something we'll need to support multiple loopbacks for example for network namespaces. Eric Biederman has written a nice patch that does this. I'm using it on 2.6.23-rc2. Benjamin -- B e n j a m i n T h e r y - BULL/DT/Open Software R&D http://www.bull.com - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists