netdev - Re: [PATCH 3/4 - rev 2] Initilize and populate age field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070821105542.GN32236@postel.suug.ch>
Date:	Tue, 21 Aug 2007 12:55:42 +0200
From:	Thomas Graf <tgraf@...g.ch>
To:	Varun Chandramohan <varunc@...ux.vnet.ibm.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, kaber@...sh.net,
	socketcan@...tkopp.net, shemminger@...ux-foundation.org,
	krkumar2@...ibm.com, varuncha@...ibm.com
Subject: Re: [PATCH 3/4 - rev 2] Initilize and populate age field

* Varun Chandramohan <varunc@...ux.vnet.ibm.com> 2007-08-20 13:46
> The age field is filled with the current time at the time of creation of the route. When the routes are dumped
> then the age value stored in the route structure is subtracted from the current time value and the difference is the age expressed in secs.
> 
> Signed-off-by: Varun Chandramohan <varunc@...ux.vnet.ibm.com>
> @@ -985,6 +987,14 @@ int fib_dump_info(struct sk_buff *skb, u
>  			NLA_PUT_U32(skb, RTA_FLOW, fi->fib_nh[0].nh_tclassid);
>  #endif
>  	}
> +
> +	do_gettimeofday(&tv);
> +	if (!*age) {
> +		*age = timeval_to_sec(&tv);
> +		NLA_PUT_U32(skb, RTA_AGE, *age);

Why don't you take the timestamp at the time of allocating the alias?
This time-since-first-dump is very confusing.

> +	} else {
> +		NLA_PUT_U32(skb, RTA_AGE, timeval_to_sec(&tv) - *age);
> +	}
>  #ifdef CONFIG_IP_ROUTE_MULTIPATH
>  	if (fi->fib_nhs > 1) {
>  		struct rtnexthop *rtnh;
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html