lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 21 Aug 2007 13:27:35 +0200
From:	Thomas Graf <tgraf@...g.ch>
To:	Varun Chandramohan <varunc@...ux.vnet.ibm.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, kaber@...sh.net,
	socketcan@...tkopp.net, shemminger@...ux-foundation.org,
	krkumar2@...ibm.com, varuncha@...ibm.com
Subject: Re: [PATCH 3/4 - rev 2] Initilize and populate age field

* Varun Chandramohan <varunc@...ux.vnet.ibm.com> 2007-08-21 16:52
> I know its a bit confusing but let me explain the reason. In my first
> version patch i used fn_hash_insert() (place where alias is created)as
> place to insert my current time in the age field.
> This will eventually call fib_dump_info() for inserting the age filed
> attribute into the skb. Now in both places i have to call
> do_gettimeofday(). Its obvious that i need it in fn_hash_insert(), its
> also need in fib_dump_info() as it is the same function called for
> retrieving and dumping the age value to the userspace. So as you are
> aware that before we dump it to userspace we need to subtract the value
> with current time i need to call do_gettimeofday() twice. To avoid this
> i did as above.

At least put a comment there, it's far from obvious.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists