netdev - Re: [PATCH] DM9000: fix interface hang under load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070823101609.GI9315@Chamillionaire.breakpoint.cc>
Date:	Thu, 23 Aug 2007 12:16:09 +0200
From:	Florian Westphal <fw@...len.de>
To:	Ben Dooks <ben@...ff.org>
Cc:	akpm@...ux-foundation.org, jgarzik@...ox.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] DM9000: fix interface hang under load

Ben Dooks <ben@...ff.org> wrote:
> On Tue, Aug 21, 2007 at 01:33:42AM +0200, Florian Westphal wrote:
> > @@ -700,6 +700,7 @@ dm9000_init_dm9000(struct net_device *dev)
[..]
> >  	} else {
> >  		/* Second packet */
> > -		db->tx_pkt_cnt++;
> >  		db->queue_pkt_len = skb->len;
> > +		netif_stop_queue(dev);
> >  	}

> If I read this correctly, you've moved the netif_{stop,start}_queue()
> calls so that the queue is only stopped if we have loaded 2 packets
> into the chip instead of stopping and starting each time.

Yes. For those that are not familiar with the dm9000 driver:
The queue is started again when a packet has been sent.

Thanks for taking the time to review this.

Florian
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html