netdev - Re: [PATCH 1/2] E1000: Fix ifdown hang in git-2.6.24

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 23 Aug 2007 09:11:01 -0700
From:	"Kok, Auke" <auke-jan.h.kok@...el.com>
To:	davem@...emloft.net
CC:	Krishna Kumar <krkumar2@...ibm.com>, netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] E1000: Fix ifdown hang in git-2.6.24

Krishna Kumar wrote:
> Doing napi_disable twice hangs "ifdown" of the device. e1000_down is the
> common place to call napi_disable.
> 
> Signed-off-by: Krishna Kumar <krkumar2@...ibm.com>
> ---
>  e1000_main.c |    4 ----
>  1 files changed, 4 deletions(-)
> 
> diff -ruNp org/drivers/net/e1000/e1000_main.c new/drivers/net/e1000/e1000_main.c
> --- org/drivers/net/e1000/e1000_main.c	2007-08-23 13:32:16.000000000 +0530
> +++ new/drivers/net/e1000/e1000_main.c	2007-08-23 13:32:34.000000000 +0530
> @@ -1477,10 +1477,6 @@ e1000_close(struct net_device *netdev)
>  {
>  	struct e1000_adapter *adapter = netdev_priv(netdev);
>  
> -#ifdef CONFIG_E1000_NAPI
> -	napi_disable(&adapter->napi);
> -#endif
> -
>  	WARN_ON(test_bit(__E1000_RESETTING, &adapter->flags));
>  	e1000_down(adapter);
>  	e1000_power_down_phy(adapter);

Acked-by: Auke Kok <auke-jan.h.kok@...el.com>

I pushed this change to akpm for -mm as well in e1000e...

Thanks Krishna,

Auke
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html