lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 23 Aug 2007 13:08:30 -0400 From: "John W. Linville" <linville@...driver.com> To: Johannes Berg <johannes@...solutions.net> Cc: Joe Perches <joe@...ches.com>, "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org Subject: Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC_ARG On Thu, Aug 23, 2007 at 06:12:00PM +0200, Johannes Berg wrote: > On Thu, 2007-08-23 at 09:01 -0700, Joe Perches wrote: > > There are also several different uses of the equivalent of > > > > printk("%02x",addr[0]) > > for (i=1; i<6; i++) > > printk(":%02x",addr[i]); > > > > to print an ethernet MAC address. > > Hm. I didn't know that, I can go through in a later patch if desired. > > > http://www.uwsg.iu.edu/hypermail/linux/net/0602.1/0002.html > > > > As not all device MAC addresses are 6 bytes, colon separated, > > perhaps an appropriate ethernet/tr MAC designation is EUI48. > > > > http://standards.ieee.org/regauth/oui/tutorials/EUI48.html > > Practically, however, nobody is going to even find macros named > EUI48_FMT/EUI48_ARG, would they? I don't much care, but I find it rather > unsatisfying that both wireless code bases define these macros. Yeah, accomodating non-48-bit MAC addresses is a bit pedantic. I ACK the original patch, FWIW. John -- John W. Linville linville@...driver.com - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists