lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 23 Aug 2007 15:03:07 -0700 From: Divy Le Ray <divy@...lsio.com> To: Al Viro <viro@....linux.org.uk> CC: Jeff Garzik <jeff@...zik.org>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Steve Wise <swise@...ngridcomputing.com> Subject: Re: [PATCH 0/3] cxgb3 driver update Hi Al, > Speaking of cxgb3, could you explain what the hell is > static int do_term(struct t3cdev *dev, struct sk_buff *skb) > { > unsigned int hwtid = ntohl(skb->priority) >> 8 & 0xfffff; > doing? AFAIK, skb->priority is not net-endian... > the RDMA connection id is saved in the skb's priority field for TERM messages because it is not in the CPL message that comes up from the hardware. Yet the RDMA driver needs it, so sge.c::process_responses() overloads the skb's priority and csum with these values. > > Another odd place is > int t3_seeprom_write(struct adapter *adapter, u32 addr, u32 data) > { > u16 val; > int attempts = EEPROM_MAX_POLL; > unsigned int base = adapter->params.pci.vpd_cap_addr; > > if ((addr >= EEPROMSIZE && addr != EEPROM_STAT_ADDR) || (addr > & 3)) > return -EINVAL; > > pci_write_config_dword(adapter->pdev, base + PCI_VPD_DATA, > cpu_to_le32(data)); > with callers like > int t3_seeprom_wp(struct adapter *adapter, int enable) > { > return t3_seeprom_write(adapter, EEPROM_STAT_ADDR, enable ? > 0xc : 0); > > IOW, you really get little-endian values passed to > pci_write_config_dword() > and it expects a host-endian as the last argument... > It looks like a bug. Thanks for spotting this. Cheers, Divy - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists