netdev - [PATCH] isdn capi driver broken on 64 bit.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 24 Aug 2007 11:08:11 -0700
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	Karsten Keil <kkeil@...e.de>
Cc:	isdn4linux@...tserv.isdn4linux.de, netdev@...r.kernel.org
Subject: [PATCH] isdn capi driver broken on 64 bit.

The following driver API is broken on any architecture with 64 bit addresses.
because of cast that loses high bits.

Signed-off-by: Stephen Hemminger <shemminger@...ux-foundation.org>

--- a/drivers/isdn/capi/capidrv.c	2007-06-25 09:03:12.000000000 -0700
+++ b/drivers/isdn/capi/capidrv.c	2007-08-24 11:06:46.000000000 -0700
@@ -1855,6 +1855,9 @@ static int if_sendbuf(int id, int channe
 		return 0;
 	}
 	datahandle = nccip->datahandle;
+
+	/* This won't work on 64 bit! */
+	BUILD_BUG_ON(sizeof(skb->data) > sizeof(u32));
 	capi_fill_DATA_B3_REQ(&sendcmsg, global.ap.applid, card->msgid++,
 			      nccip->ncci,	/* adr */
 			      (u32) skb->data,	/* Data */
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html