lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 24 Aug 2007 13:11:04 -0500 From: Olof Johansson <olof@...om.net> To: Stephen Rothwell <sfr@...b.auug.org.au> Cc: netdev@...r.kernel.org, jgarzik@...ox.com, linuxppc-dev@...abs.org Subject: Re: [PATCH v2] [02/10] pasemi_mac: Stop using the pci config space accessors for register read/writes On Fri, Aug 24, 2007 at 02:05:31PM +1000, Stephen Rothwell wrote: > On Thu, 23 Aug 2007 13:13:10 -0500 Olof Johansson <olof@...om.net> wrote: > > > > out: > > - pci_dev_put(mac->iob_pdev); > > -out_put_dma_pdev: > > - pci_dev_put(mac->dma_pdev); > > -out_free_netdev: > > + if (mac->iob_pdev) > > + pci_dev_put(mac->iob_pdev); > > + if (mac->dma_pdev) > > + pci_dev_put(mac->dma_pdev); > > It is not documented as such (as far as I can see), but pci_dev_put is > safe to call with NULL. And there are other places in the kernel that > explicitly use that fact. Some places check, others do not. I'll leave it be for now but might take care of it during some future cleanup. Thanks for point it out though. -Olof - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists