netdev - Re: [PATCH] phy layer: fix genphy_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46CFB2CB.1040400@garzik.org>
Date:	Sat, 25 Aug 2007 00:40:43 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Domen Puncer <domen.puncer@...argo.com>
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH] phy layer: fix genphy_setup_forced (don't reset)

Domen Puncer wrote:
> Writing BMCR_RESET bit will reset MII_BMCR to default values. This is
> clearly not what we want.
> 
> 
> Signed-off-by: Domen Puncer <domen.puncer@...argo.com>
> 
> ---
>  drivers/net/phy/phy_device.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: work-powerpc.git/drivers/net/phy/phy_device.c
> ===================================================================
> --- work-powerpc.git.orig/drivers/net/phy/phy_device.c
> +++ work-powerpc.git/drivers/net/phy/phy_device.c
> @@ -364,7 +364,7 @@ EXPORT_SYMBOL(genphy_config_advert);
>   */
>  int genphy_setup_forced(struct phy_device *phydev)
>  {
> -	int ctl = BMCR_RESET;
> +	int ctl = 0;
>  
>  	phydev->pause = phydev->asym_pause = 0;

applied


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html