netdev - Re: [PATCH] net/802: indentation cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070824.224220.34754828.davem@davemloft.net>
Date:	Fri, 24 Aug 2007 22:42:20 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...ux-foundation.org
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net/802: indentation cleanup

From: David Miller <davem@...emloft.net>
Date: Fri, 24 Aug 2007 22:39:40 -0700 (PDT)

> From: Stephen Hemminger <shemminger@...ux-foundation.org>
> Date: Fri, 17 Aug 2007 18:53:11 -0700
> 
> > Run the 802 related protocols through Lindent (and hand cleanup)
> > to fix indentation and whitespace style issues.
> 
> Applied to net-2.6.24, thanks.

Actually reverted.

Nothing in the world makes me more furious than a "coding
style" change that wasn't even compile tested.

net/802/tr.c: In function .$,1rx.(Btr_add_rif_info.$,1ry.(B:
net/802/tr.c:400: error: expected identifier before .$,1rx.(B!.$,1ry.(B token

Stephen I see you do things like this, forget sign offs,
and many other things that all say in big huge letters
"sloppy".

Please shape up and test your changes no matter how trivial.

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html