netdev - Re: [PATCH 4/5] [TCP]: Discard fuzzy SACK blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070824.225529.43496742.davem@davemloft.net>
Date:	Fri, 24 Aug 2007 22:55:29 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ilpo.jarvinen@...sinki.fi
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 4/5] [TCP]: Discard fuzzy SACK blocks

From: "Ilpo_Järvinen" <ilpo.jarvinen@...sinki.fi>
Date: Mon, 20 Aug 2007 16:16:32 +0300

> SACK processing code has been a sort of russian roulette as no
> validation of SACK blocks is previously attempted. Besides, it
> is not very clear what all kinds of broken SACK blocks really
> mean (e.g., one that has start and end sequence numbers
> reversed). So now close the roulette once and for all.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>

Thanks a lot for coding this up, I like it a lot, applied.

I have some minor worries about the D-SACK lower bound, but
it's probably OK and I'm just being paranoid :-)
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html