netdev - Re: net-2.6.24 build broken (allyesconfig)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1188219179.7837.15.camel@johannes.berg>
Date:	Mon, 27 Aug 2007 14:52:59 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>
Cc:	"John W. Linville" <linville@...driver.com>,
	"David S. Miller" <davem@...emloft.net>,
	Netdev <netdev@...r.kernel.org>
Subject: Re: net-2.6.24 build broken (allyesconfig)

On Mon, 2007-08-27 at 15:32 +0300, Ilpo Järvinen wrote:

> drivers/net/82596.c:1618:1: error: unterminated argument list invoking 
> macro "DEB"

> Hmm, I would guess that "[NET]: Introduce MAC_FMT/MAC_ARG" broken it, 
> though didn't verify it.
> 
> The fix is left as an exercise of the reader (i.e., the solution wasn't 
> too obvious for me :-) )...

Yup, my fault, sorry about that.

From: Johannes Berg <johannes@...solutions.net>
Subject: fix MAC_FMT/MAC_ARG in 82596.c

This fixes a typo in commit f98d4ca4986fec.

Signed-off-by: Johannes Berg <johannes@...solutions.net>

---
 drivers/net/82596.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- netdev-2.6.orig/drivers/net/82596.c	2007-08-27 14:48:19.674646075 +0200
+++ netdev-2.6/drivers/net/82596.c	2007-08-27 14:48:21.674646075 +0200
@@ -1562,7 +1562,7 @@ static void set_multicast_list(struct ne
 			memcpy(cp, dmi->dmi_addr, 6);
 			if (i596_debug > 1)
 				DEB(DEB_MULTI,printk(KERN_INFO "%s: Adding address " MAC_FMT "\n",
-						dev->name, MAC_ARG(cp));
+						dev->name, MAC_ARG(cp)));
 		}
 		i596_add_cmd(dev, &cmd->cmd);
 	}


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html