netdev - Re: [PATCH V4 10/10] net/bonding: Destroy bonding master when last slave is gone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 28 Aug 2007 16:33:06 -0700
From:	Jay Vosburgh <fubar@...ibm.com>
To:	Moni Shoua <monis@...taire.com>
cc:	rdreier@...co.com, davem@...emloft.net, netdev@...r.kernel.org,
	general@...ts.openfabrics.org
Subject: Re: [PATCH V4 10/10] net/bonding: Destroy bonding master when last slave is gone 

Moni Shoua <monis@...taire.com> wrote:

>When bonding enslaves non Ethernet devices it takes pointers to functions 
>in the module that owns the slaves. In this case it becomes unsafe
>to keep the bonding master registered after last slave was unenslaved 
>because we don't know if the pointers are still valid.  Destroying the bond when slave_cnt is zero
>ensures that these functions be used anymore.

	Would it not be simpler to run the bonding master through
ether_setup() again when the final slave is released (to reset all of
the pointers to their "ethernet" values)?  I'm presuming here the
pointers of questionable validity are the ones set in the
bond_setup_by_slave() copied from the slave_dev->hard_header, et al.

	Having the bonding master disappear (but only sometimes) after
the last slave is removed is a semantic change I'd rather not introduce
if it's not necessary.

	-J

---
	-Jay Vosburgh, IBM Linux Technology Center, fubar@...ibm.com
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html