netdev - [PATCH] PS3: fix the bug that 'ifconfig down' would hang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070828125924.C2B1.MOKUNO@sm.sony.co.jp>
Date:	Tue, 28 Aug 2007 13:18:15 +0900
From:	Masakazu Mokuno <mokuno@...sony.co.jp>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	netdev@...r.kernel.org, "Michael Lothian" <mike@...eburn.co.uk>,
	"Stefan Assmann" <sassmann@...e.de>, geoffrey.levand@...sony.com,
	Geert Uytterhoeven <Geert.Uytterhoeven@...ycom.com>,
	cbe-oss-dev@...abs.org, ppc@...e.de,
	Linas Vepstas <linas@...tin.ibm.com>
Subject: [PATCH] PS3: fix the bug that 'ifconfig down' would hang

Fix the bug that 'ifconfig eth0 down' would hang up, reported by Stefan
Assmann <sassmann@...e.de>.
As we removed netif_poll_enable() from dev->open(), we should not use 
netif_poll_disable() in dev->stop(). 

Signed-off-by: Masakazu Mokuno <mokuno@...sony.co.jp>
CC: Geoff Levand <geoffrey.levand@...sony.com>
---
 drivers/net/ps3_gelic_net.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/net/ps3_gelic_net.c
+++ b/drivers/net/ps3_gelic_net.c
@@ -556,7 +556,6 @@ static int gelic_net_stop(struct net_dev
 {
 	struct gelic_net_card *card = netdev_priv(netdev);
 
-	netif_poll_disable(netdev);
 	netif_stop_queue(netdev);
 
 	/* turn off DMA, force end */


--
Masakazu MOKUNO

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html