netdev - Re: [E1000-devel] [PATCH net-2.6.24] e100: fix driver init lockup on e100

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46D447F6.8050809@katalix.com>
Date:	Tue, 28 Aug 2007 17:06:14 +0100
From:	James Chapman <jchapman@...alix.com>
To:	David Miller <davem@...emloft.net>
CC:	auke-jan.h.kok@...el.com, netdev@...r.kernel.org,
	e1000-devel@...ts.sourceforge.net
Subject: Re: [E1000-devel] [PATCH net-2.6.24] e100: fix driver init lockup
 on e100_up()

David Miller wrote:
> From: James Chapman <jchapman@...alix.com>
> Date: Tue, 28 Aug 2007 09:22:36 +0100
> 
>> I like this idea. A quick survey of other NAPI drivers doesn't show any 
>> that do an explicit napi_disable() at init, though they might do so from 
>> internal functions. Each driver would need to be examined to check that 
>> it won't hang the same way as e100, so adding the call to 
>> netif_napi_add() would just be easier.
> 
> Yes.  And that's what I've been working on most of tonight.
> 
> Here is the new NAPI patch that I'll spin into the net-2.6.24 tree
> after I go over it some more and do some minimal testing.
> 
> [NET]: Make NAPI polling independent of struct net_device objects.

This patch version works fine with e100 and 8139cp. Please drop my e100 
fixup patch.

-- 
James Chapman
Katalix Systems Ltd
http://www.katalix.com
Catalysts for your Embedded Linux software development

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html