netdev - Re: [PATCH 5/5] Net: ath5k, kconfig changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070828171330.GD29343@infradead.org>
Date:	Tue, 28 Aug 2007 18:13:30 +0100
From:	Christoph Hellwig <hch@...radead.org>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	linville@...driver.com, linux-kernel@...r.kernel.org,
	linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 5/5] Net: ath5k, kconfig changes

On Tue, Aug 28, 2007 at 12:01:30PM -0400, Jiri Slaby wrote:
> +config ATH5K_AR5210
> +	bool "Support AR5210"
> +	depends on ATH5K
> +	default y
> +
> +config ATH5K_AR5211
> +	bool "Support AR5211"
> +	depends on ATH5K
> +	default y
> +
> +config ATH5K_AR5212
> +	bool "Support AR5212"
> +	depends on ATH5K
> +	default y

Please don't add more default statements.

Also this whole patch seems rather pointless.  It saves only
very little and turns the driver into a complete ifdef maze.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html