lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 30 Aug 2007 04:50:01 +0300 From: "Nick Kossifidis" <mickflemm@...il.com> To: "Christoph Hellwig" <hch@...radead.org> Cc: "Jiri Slaby" <jirislaby@...il.com>, linville@...driver.com, linux-wireless@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH 1/5] Net: ath5k, split hw into hw, phy and initvals 2007/8/28, Christoph Hellwig <hch@...radead.org>: > On Tue, Aug 28, 2007 at 11:58:52AM -0400, Jiri Slaby wrote: > > -ath5k-objs = ath5k_base.o ath5k_hw.o ath5k_regdom.o > > +ath5k-objs = ath5k_base.o ath5k_hw.o ath5k_regdom.o \ > > + ath5k_hw_phy.o ath5k_hw_inivals.o > > And while I'm at nitpicking :) > > ath5k_hw_phy.o should probably be ath5k_phy.o by conventions used by > most drivers and ath5k_hw_inivals.o mights aswell be something like > ath5k_init.o > If you check out the code you'll see i'm using the same convention inside them, ath5k_hw* files contain hw related functions (ath5k_hw_<name>) while driver code has ath5k_<name>. Also ath5k_init is misleading, file acually includes initial register settings for various chips and the functions to apply them on hw, not the initialization/attach/wakeup etc routines (that can be found in ath5k_hw.c), that's why it's inivals, i couldn't find a more appropriate name. -- GPG ID: 0xD21DB2DB As you read this post global entropy rises. Have Fun ;-) Nick - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists