netdev - Re: oops with recent wireless-dev tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1188475530.2963.20.camel@johannes.berg>
Date:	Thu, 30 Aug 2007 14:05:30 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Jochen Voss <voss@...huhn.de>
Cc:	linux wireless list <linux-wireless@...r.kernel.org>,
	linville@...driver.com, netdev <netdev@...r.kernel.org>,
	shemminger@...ux-foundation.org
Subject: Re: oops with recent wireless-dev tree

Hi Jochen,

[added CCs since it affects bridge code]

> If I read this correctly, the EIP in the last line corresponds to
> net/bridge/br_if.c, line 36:
> 
>     static int port_cost(struct net_device *dev)
>     {
> 	    if (dev->ethtool_ops->get_settings) {
>                                ^^^^
> 
> As far as I can figure out, dev->ethtool_ops is NULL and the crash
> happens while trying to derefernce ...->get_settings.
> 
> Is dev->ethtool_ops allowed to be NULL?  In this case the appended
> patch might be the correct fix.  At least it makes the oops disappear
> for me.  Another possible fix would be to add an ethtool_ops structure
> to the device created by b43.

I don't think adding ethtool_ops in mac80211 should be necessary.
Stephen?

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (191 bytes)