lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 30 Aug 2007 18:58:36 -0300 From: Arnaldo Carvalho de Melo <acme@...stprotocols.net> To: dhananjay@...xen.com Cc: netdev@...r.kernel.org, jeff@...zik.org, rob@...xen.com Subject: Re: [PATCH 1/3] netxen: Avoid firmware load in PCI probe Em Tue, Aug 28, 2007 at 05:23:25PM +0530, dhananjay@...xen.com escreveu: > Loading firmware during PCI probe can lead to incorrect initialization, > rendering the card unusable until next reboot. This was introduced a while > ago as a workaround for firmware bug, a better workaround was submitted for > this a while ago. So removing original hack that loads firmware during probe. > > Signed-off by: Dhananjay Phadke <dhananjay@...xen.com> Acked-by: Arnaldo Carvalho de Melo <acme@...hat.com> I was having these problems and after applying this patch the NIC is back working, thank you for fixing this! - Arnaldo > Index: netdev-2.6/drivers/net/netxen/netxen_nic_main.c > =================================================================== > --- netdev-2.6.orig/drivers/net/netxen/netxen_nic_main.c > +++ netdev-2.6/drivers/net/netxen/netxen_nic_main.c > @@ -639,10 +639,6 @@ netxen_nic_probe(struct pci_dev *pdev, c > NETXEN_CRB_NORMALIZE(adapter, > NETXEN_ROMUSB_GLB_PEGTUNE_DONE)); > /* Handshake with the card before we register the devices. */ > - writel(0, NETXEN_CRB_NORMALIZE(adapter, CRB_CMDPEG_STATE)); > - netxen_pinit_from_rom(adapter, 0); > - msleep(1); > - netxen_load_firmware(adapter); > netxen_phantom_init(adapter, NETXEN_NIC_PEG_TUNE); > } - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists