netdev - Re: [PATCH 13/30] net: Don't do pointless kmalloc return value casts in zd1211 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46D756FF.3090602@gentoo.org>
Date:	Thu, 30 Aug 2007 19:47:11 -0400
From:	Daniel Drake <dsd@...too.org>
To:	Jesper Juhl <jesper.juhl@...il.com>
CC:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Ulrich Kunitz <kune@...ne-taler.de>,
	linux-wireless@...r.kernel.org
Subject: Re: [PATCH 13/30] net: Don't do pointless kmalloc return value casts
 in zd1211 driver

Jesper Juhl wrote:
> What would be wrong in applying my patch that removes the cast of the
> kmalloc() return value and then also remove the "__nocast" here?

We use it as a safety measure when coding. For example the write 
register function takes an address and a value. We got one of these the 
wrong way round once, and had a non-obvious bug.

nocast and sparse helps us prevent this.

Daniel

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html