netdev - Re: [PATCH 1/2 v2] PS3: changed the way to handle tx skbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46D81EDD.5090807@garzik.org>
Date:	Fri, 31 Aug 2007 09:59:57 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Masakazu Mokuno <mokuno@...sony.co.jp>
CC:	Linas Vepstas <linas@...tin.ibm.com>, netdev@...r.kernel.org,
	cbe-oss-dev@...abs.org, geoffrey.levand@...sony.com,
	Geert Uytterhoeven <Geert.Uytterhoeven@...ycom.com>
Subject: Re: [PATCH 1/2 v2] PS3: changed the way to handle tx skbs

Masakazu Mokuno wrote:
> The PS3 virtual network device requires a vlan tag in the sending packet
> to select the destination device, ethernet port or wireless. 
> As the vlan tag field is in the middle of the passed data, 
> we should insert it into the packet data.
> To avoid copying much of the packet data, the driver used two tx descriptors
> for one tx skb; one descriptor was for sending a small static 
> buffer which contained vlan tag and copied header (two mac addresses),
> one was for the residual data after the vlan field.
> 
> This patch changes the way to insert the vlan tag.  By changing 
> netdev->hard_header_len, we can make the headroom for moving mac address
> fields in the skb buffer. Then we can send one tx skb with
> one tx descriptor.  This also gives us a tx throughut gain of approx.
> 20% according to netperf results.
> 
> Signed-off-by: Masakazu Mokuno <mokuno@...sony.co.jp>
> CC: Geoff Levand <geoffrey.levand@...sony.com>
> ---
>  drivers/net/ps3_gelic_net.c |  140 +++++++++++++++++++-------------------------
>  1 file changed, 63 insertions(+), 77 deletions(-)

applied 1-2, thanks for the update


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html