netdev - Re: [PATCH] bridge: fix OOPS when bridging device without ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070830.221642.41875712.davem@davemloft.net>
Date:	Thu, 30 Aug 2007 22:16:42 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	matthew@....cx
Cc:	shemminger@...ux-foundation.org, johannes@...solutions.net,
	voss@...huhn.de, linux-wireless@...r.kernel.org,
	linville@...driver.com, netdev@...r.kernel.org,
	bridge@...ux-foundation.org
Subject: Re: [PATCH] bridge: fix OOPS when bridging device without ethtool

From: Matthew Wilcox <matthew@....cx>
Date: Thu, 30 Aug 2007 10:48:13 -0600

> On Thu, Aug 30, 2007 at 08:29:32AM -0700, Stephen Hemminger wrote:
> > Bridge code calls ethtool to get speed. The conversion to using
> > only ethtool_ops broke the case of devices without ethtool_ops.
> > This is a new regression in 2.6.23.
> > 
> > Rearranged the switch to a logical order, and use gcc initializer.
> > 
> > Ps: speed should have been part of the network device structure from
> >     the start rather than burying it in ethtool.
> 
> Feel free to do the conversion ;-)  One of the things I like about the
> ethtool framework is it gives us a way to take stuff out of the drivers
> and put it in the midlayer without disturbing userspace.
> 
> > Signed-off-by: Stephen Hemminger <shemminger@...ux-foundation.org>
> 
> Acked-by: Matthew Wilcox <matthew@....cx>

Applied, thanks!
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html