netdev - Re: [PATCH] [NET_SCHED] sch_prio.c: remove duplicate call of tc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 30 Aug 2007 22:36:06 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	lucas.nussbaum@...g.fr
Cc:	netdev@...r.kernel.org, kaber@...sh.net
Subject: Re: [PATCH] [NET_SCHED] sch_prio.c: remove duplicate call of
 tc_classify()

From: Lucas Nussbaum <lucas.nussbaum@...g.fr>
Date: Thu, 30 Aug 2007 09:28:17 +0200

> Hi,
> 
> When CONFIG_NET_CLS_ACT is enabled, tc_classify() is called twice in
> prio_classify(). This causes "interesting" behaviour: with the setup
> below, packets are duplicated, sent twice to ifb0, and then loop in and
> out of ifb0.
> 
> The patch uses the previously calculated return value in the switch,
> which is probably what Patrick had in mind in commit
> bdba91ec70fb5ccbdeb1c7068319adc6ea9e1a7d -- maybe Patrick can
> double-check this?
> 
> -- example setup --
> ifconfig ifb0 up
> tc qdisc add dev ifb0 root netem delay 2s
> tc qdisc add dev $ETH root handle 1: prio
> tc filter add dev $ETH parent 1: protocol ip prio 10 u32 \
>  match ip dst 172.24.110.6/32 flowid 1:1 \
>  action mirred egress redirect dev ifb0
> ping -c1 172.24.110.6
> 
> Signed-off-by: Lucas Nussbaum <lucas.nussbaum@...g.fr>

Thank you for finding and fixing this bug, patch applied.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html