| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <E1IR2XK-0007Q4-00@gondolin.me.apana.org.au> Date: Fri, 31 Aug 2007 17:11:30 +0800 From: Herbert Xu <herbert@...dor.apana.org.au> To: James Chapman <jchapman@...alix.com>, "David S. Miller" <davem@...emloft.net>, Michal Ostrowski <mostrows@...akeasy.net>, Paul Mackerras <paulus@...ba.org>, Herbert Xu <herbert@...dor.apana.org.au>, Toralf F?rster <toralf.foerster@....de>, netdev@...r.kernel.org Subject: [PATCH 1/7] [PPP] pppoe: Fix skb_unshare_check call position [PPP] pppoe: Fix skb_unshare_check call position The skb_unshare_check call needs to be made before pskb_may_pull, not after. Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au> --- drivers/net/pppoe.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/pppoe.c b/drivers/net/pppoe.c index 68631a5..5ac3eff 100644 --- a/drivers/net/pppoe.c +++ b/drivers/net/pppoe.c @@ -385,12 +385,12 @@ static int pppoe_rcv(struct sk_buff *skb, struct pppoe_hdr *ph; struct pppox_sock *po; - if (!pskb_may_pull(skb, sizeof(struct pppoe_hdr))) - goto drop; - if (!(skb = skb_share_check(skb, GFP_ATOMIC))) goto out; + if (!pskb_may_pull(skb, sizeof(struct pppoe_hdr))) + goto drop; + ph = pppoe_hdr(skb); po = get_item((unsigned long) ph->sid, eth_hdr(skb)->h_source, dev->ifindex); - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists