lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <Pine.LNX.4.64.0708310803260.13296@x2> Date: Fri, 31 Aug 2007 08:04:31 +0200 (CEST) From: Patrick McHardy <kaber@...sh.net> To: Lucas Nussbaum <lucas.nussbaum@...g.fr> cc: netdev@...r.kernel.org Subject: Re: [PATCH] [NET_SCHED] sch_prio.c: remove duplicate call of tc_classify() On Thu, 30 Aug 2007, Lucas Nussbaum wrote: > When CONFIG_NET_CLS_ACT is enabled, tc_classify() is called twice in > prio_classify(). This causes "interesting" behaviour: with the setup > below, packets are duplicated, sent twice to ifb0, and then loop in and > out of ifb0. > > The patch uses the previously calculated return value in the switch, > which is probably what Patrick had in mind in commit > bdba91ec70fb5ccbdeb1c7068319adc6ea9e1a7d -- maybe Patrick can > double-check this? > err = tc_classify(skb, q->filter_list, &res); > #ifdef CONFIG_NET_CLS_ACT > - switch (tc_classify(skb, q->filter_list, &res)) { > + switch (err) { Indeed, thats what I intended to do, thanks Lucas. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists