netdev - Re: [PATCH] skge: unbalanced parenthesis fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070901135539.40557930@oldman>
Date:	Sat, 1 Sep 2007 13:55:39 +0100
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	Mariusz Kozlowski <m.kozlowski@...land.pl>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	lkml <linux-kernel@...r.kernel.org>, netdev@...r.kernel.org
Subject: Re: [PATCH] skge: unbalanced parenthesis fix

On Sat, 1 Sep 2007 08:10:12 +0200
Mariusz Kozlowski <m.kozlowski@...land.pl> wrote:

> Hello,
> 
> 	This patch fixes unbalanced parenthesis.
> 
> Signed-off-by: Mariusz Kozlowski <m.kozlowski@...land.pl>
> 
>  drivers/net/skge.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-2.6.23-rc4-mm1-a/drivers/net/skge.h	2007-09-01 07:23:52.000000000 +0200
> +++ linux-2.6.23-rc4-mm1-b/drivers/net/skge.h	2007-09-01 07:37:55.000000000 +0200
> @@ -1351,7 +1351,7 @@ enum {
>  	PHY_M_PC_EN_DET_PLUS	= 3<<8, /* Energy Detect Plus (Mode 2) */
>  };
> 
> -#define PHY_M_PC_MDI_XMODE(x)	((((u16)(x)<<5) & PHY_M_PC_MDIX_MSK)
> +#define PHY_M_PC_MDI_XMODE(x)	(((u16)(x)<<5) & PHY_M_PC_MDIX_MSK)
> 
>  enum {
>  	PHY_M_PC_MAN_MDI	= 0, /* 00 = Manual MDI configuration */

Since the macro is unused, I would rather just drop it.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html