netdev - Re: [PATCH 1/2]: [NET_SCHED]: Make all rate based scheduler work with TSO.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.61.0709012325080.29796@ask.diku.dk>
Date:	Sat, 1 Sep 2007 23:38:23 +0200 (CEST)
From:	Jesper Dangaard Brouer <hawk@...u.dk>
To:	Patrick McHardy <kaber@...sh.net>
Cc:	jdb@...x.dk, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH 1/2]: [NET_SCHED]: Make all rate based scheduler work
 with TSO.


On Sat, 1 Sep 2007, Patrick McHardy wrote:

> Jesper Dangaard Brouer wrote:
>> commit 6fdc0f061be94f5e297650961360fb7a9d1cc85d
>> Author: Jesper Dangaard Brouer <hawk@...x.dk>
>> Date:   Thu Aug 30 17:53:42 2007 +0200
>> 
>> [NET_SCHED]: Make all rate based scheduler work with TSO.
>> 
>> Change L2T (length to time) macros, in all rate based schedulers, to
>> call a common function qdisc_l2t() that does the rate table lookup.
>> This function handles if the packet size lookup is larger than the
>> rate table, which often occurs with TSO enabled.
>
>
> It still won't work properly with TSO (TBF for example already drops
> oversized packets during ->enqueue), but its a good cleanup anyway.

Then lets call it a cleanup of the L2T macros.  In the next step we will 
fix the different schedulers, to use the ability to lookup larger sized 
packets. (I did notice the TBF scheduler would drop oversized packets).


>> +#define L2T(p,L)   ((p)->tcfp_R_tab, L)
>> +#define L2T_P(p,L) ((p)->tcfp_P_tab, L)
>
>
> I'd prefer to get rid of these L2T macros completely.

Lets take it one step at a time, but I agree.


Will you ack the patch as a cleanup?

Hilsen
   Jesper Brouer

--
-------------------------------------------------------------------
MSc. Master of Computer Science
Dept. of Computer Science, University of Copenhagen
Author of http://www.adsl-optimizer.dk
-------------------------------------------------------------------
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html