netdev - Re: [RFC PATCH v0.2] net driver: mpc52xx fec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fa686aa40709030941x1dee3898ud881497b534cc6aa@mail.gmail.com>
Date:	Mon, 3 Sep 2007 10:41:51 -0600
From:	"Grant Likely" <grant.likely@...retlab.ca>
To:	"Jon Smirl" <jonsmirl@...il.com>
Cc:	"Domen Puncer" <domen@...erock.org>, netdev@...r.kernel.org,
	linuxppc-embedded@...abs.org
Subject: Re: [RFC PATCH v0.2] net driver: mpc52xx fec

On 9/3/07, Jon Smirl <jonsmirl@...il.com> wrote:
> On 9/3/07, Grant Likely <grant.likely@...retlab.ca> wrote:
> > On 9/2/07, Domen Puncer <domen@...erock.org> wrote:
> > > Hi!
> > >
> > > new in this version:
> > > - fixed stuff that was commented on.
> > > - added 7-wire support (compile at least, if someone has the hardware,
> > >         please test!)
> > > - ethtool support
> >
> > Thanks for this work Domen, comments below...
> >
> > This is a large patch, and it should be broken up into logical
> > changes.  ie. split into dts changes, bestcomm changes, fec driver and
> > mdio driver.  Easier to review that way.  The bestcomm and dts changes
> > don't need to go to the netdev list.
>
> A similar patch that is already broken up is available for Efika.
> http://dev.gentoo.org/~nixnut/efika/efika-patches-2.6.22.tar.bz2

No.  That series is Sylvain's full patchset including the old FEC
driver.  Domen's patch is a reworked FEC driver, and it only replaces
patch 0008 from that series.  However, this patch should be split up
further because it makes changes to both the device tree and the
bestcomm code.

Cheers,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@...retlab.ca
(403) 399-0195
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html