lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 5 Sep 2007 21:22:35 +0200 From: Francois Romieu <romieu@...zoreil.com> To: Joe Perches <joe@...ches.com> Cc: Stephen Hemminger <shemminger@...ux-foundation.org>, klassert@...hematik.tu-chemnitz.de, Jeff Garzik <jeff@...zik.org>, netdev@...r.kernel.org Subject: Re: [PATCH] 3c59x: sparse warning fix Joe Perches <joe@...ches.com> : [...] > Shouldn't this be: > > if (pkt_len < rx_copybreak) { > skb = dev_alloc_skb(pkt_len + 2); > if (!skb) { > bad_news! (like the refill rx ring buffers block) > } It is not that bad a news: the rx_copybreak optimization is lost but it is still possible to push the data up the stack. -- Ueimor - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists