netdev - Re: [PATCH 1/1] netcore: minor cleanup for register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070906.143402.07329837.yoshfuji@linux-ipv6.org>
Date:	Thu, 06 Sep 2007 14:34:02 +0900 (JST)
From:	YOSHIFUJI Hideaki / 吉藤英明 
	<yoshfuji@...ux-ipv6.org>
To:	wangchen@...fujitsu.com
Cc:	netdev@...r.kernel.org, ellre923@...il.com, yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH 1/1] netcore: minor cleanup for register_netdevice

I disagree.  Some of "dev->init()" functions set up dev->iflink;
e.g., ipip_tunnel_init() etc.

In article <46DF8FBC.20106@...fujitsu.com> (at Thu, 06 Sep 2007 13:27:24 +0800), FNST-Wang Chen <wangchen@...fujitsu.com> says:

> - minor logic cleanup
> 
> Signed-off-by: Wang Chen <wangchen@...fujitsu.com>
> 
> diff -Nurp linux-2.6.22.4.org/net/core/dev.c  linux-2.6.22.4/net/core/dev.c
> --- linux-2.6.22.4.org/net/core/dev.c    2007-08-22 15:33:40.000000000 
> +0800
> +++ linux-2.6.22.4/net/core/dev.c    2007-09-06 13:27:35.000000000 +0800
> @@ -3075,8 +3075,6 @@ int register_netdevice(struct net_device
>     dev->xmit_lock_owner = -1;
>     spin_lock_init(&dev->ingress_lock);
> 
> -    dev->iflink = -1;
> -
>     /* Init, if this function is available */
>     if (dev->init) {
>         ret = dev->init(dev);
> @@ -3093,8 +3091,7 @@ int register_netdevice(struct net_device
>     }
> 
>     dev->ifindex = dev_new_index();
> -    if (dev->iflink == -1)
> -        dev->iflink = dev->ifindex;
> +    dev->iflink = dev->ifindex;
> 
>     /* Check for existence of name */
>     head = dev_name_hash(dev->name);
> 
> 
> 
> 
> 
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html