netdev - Re: BUG: scheduling while atomic: ifconfig/0x00000002/4170

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1189091995.28781.99.camel@johannes.berg>
Date:	Thu, 06 Sep 2007 17:19:55 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	Satyam Sharma <satyam@...radead.org>,
	Florian Lohoff <flo@...822.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Netdev <netdev@...r.kernel.org>, linux-wireless@...r.kernel.org,
	Michal Piotrowski <michal.k.k.piotrowski@...il.com>,
	ipw3945-devel@...ts.sourceforge.net, yi.zhu@...el.com
Subject: Re: BUG: scheduling while atomic: ifconfig/0x00000002/4170

On Thu, 2007-09-06 at 16:23 +0800, Herbert Xu wrote:
> On Thu, Sep 06, 2007 at 10:32:33AM +0530, Satyam Sharma wrote:
> > 
> > > > [  382.529041]  [<c02c8abc>] dev_close+0x24/0x67
> > > > [  382.529052]  [<e01f402b>] ieee80211_master_stop+0x4a/0x6d [mac80211]
> 
> This is where the bug is.  You cannot call dev_close from an
> atomic context as i33380211_master_stop does it within spin
> locks.

Oh btw. Can we stick a might_sleep() into dev_close() *before* the test
whether the device is up? That way, we'd have seen the bug, but
apparently nobody before Florian ever did a 'ip link set wmaster0 down'
while the other interfaces were still open.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (191 bytes)