netdev - Re: 2.6.23-rc4-mm1: e1000e napi lockup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 09 Sep 2007 11:58:17 +0200
From:	Jiri Slaby <jirislaby@...il.com>
To:	unlisted-recipients:; (no To-header on input)
CC:	Andrew Morton <akpm@...ux-foundation.org>, netdev@...r.kernel.org,
	e1000-devel@...ts.sourceforge.net,
	Auke Kok <auke-jan.h.kok@...el.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: 2.6.23-rc4-mm1: e1000e napi lockup

On 09/07/2007 09:19 AM, Jiri Slaby wrote:
> Hi,
> 
> I found a regression in 2.6.23-rc4-mm1 (since -rc3-mm1) in e1000e driver.
> napi_disable(&adapter->napi) in e1000_probe freezes the kernel on boot.

Ok, after these changes:
diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c
index c1c64e2..f8ec537 100644
--- a/drivers/net/e1000e/netdev.c
+++ b/drivers/net/e1000e/netdev.c
@@ -1693,10 +1693,7 @@ quit_polling:
                if (adapter->itr_setting & 3)
                        e1000_set_itr(adapter);
                netif_rx_complete(poll_dev, napi);
-               if (test_bit(__E1000_DOWN, &adapter->state))
-                       atomic_dec(&adapter->irq_sem);
-               else
-                       e1000_irq_enable(adapter);
+               e1000_irq_enable(adapter);
                return 0;
        }

@@ -4257,7 +4254,6 @@ static int __devinit e1000_probe(struct pci_dev *pdev,
        /* tell the stack to leave us alone until e1000_open() is called */
        netif_carrier_off(netdev);
        netif_stop_queue(netdev);
-       napi_disable(&adapter->napi);

        strcpy(netdev->name, "eth%d");
        err = register_netdev(netdev);


I still have problems with the driver. When I do `ip link set eth0 up', ksoftirq
runs with 100 % cpu time, so I think you endlessly re-schedule some timer (or
the new napi layer?)

regards,
-- 
Jiri Slaby (jirislaby@...il.com)
Faculty of Informatics, Masaryk University
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html