netdev - Re: [PATCH][2/2] Add ICMPMsgStats MIB (RFC 4293)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OFB359CEB3.1D9E338E-ON88257353.00529BF9-88257353.00545412@us.ibm.com>
Date:	Tue, 11 Sep 2007 08:21:54 -0700
From:	David Stevens <dlstevens@...ibm.com>
To:	YOSHIFUJI Hideaki / 吉藤英明 
	<yoshfuji@...ux-ipv6.org>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	netdev-owner@...r.kernel.org, yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH][2/2] Add ICMPMsgStats MIB (RFC 4293)

Yoshifuji Hideaki <yoshfuji@...ux-ipv6.org> wrote on 09/11/2007 01:50:53 
AM:

> Dave, we've been supporting per-interface stats for IPv6, and
> you seem to remove them.  Please keep them.  Thank you.

        The reason I didn't for ICMPMsgStats is the size. The RFC requires
in & out counters for all types, whether or not they are known by the OS,
so that's 512 stats.

Because the MIB variables in the existing infrastructure are not 
dynamically
allocated, that's:

512 * numInterfaces * numCPUs * 2protos

That seems like a lot of mostly-zero memory. Changing them to be run-time
allocated (and re-allocated when new types are seen) is another 
alternative,
but more significant changes.

"Memory is Cheap."
        -- Doug Comer

So maybe it's not so bad -- I'll roll another per-interface version
to see.

                                                        +-DLS

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html