lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 11 Sep 2007 22:32:33 +0200 From: Francois Romieu <romieu@...zoreil.com> To: Stephen Hemminger <shemminger@...ux-foundation.org> Cc: Jesse Huang <jesse@...lus.com.tw>, jeff@...zik.org, akpm@...ux-foundation.org, netdev@...r.kernel.org Subject: Re: [PATCH] Add IP1000A Driver Stephen Hemminger <shemminger@...ux-foundation.org> : [...] > > + struct { > > + u32 field; > > + unsigned int len; > > + } p[] = { > > + { GMII_PREAMBLE, 32 }, /* Preamble */ > > + { GMII_ST, 2 }, /* ST */ > > + { GMII_READ, 2 }, /* OP */ > > + { phy_id, 5 }, /* PHYAD */ > > + { phy_reg, 5 }, /* REGAD */ > > + { 0x0000, 2 }, /* TA */ > > + { 0x0000, 16 }, /* DATA */ > > + { 0x0000, 1 } /* IDLE */ > > + }; > > This could be declared static const, since it doesn't change. phy_id and phy_reg do change. It can be worked around but I see no really nice solution. Any suggestion ? -- Ueimor - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists