[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <46E80ECD.8000605@andyfurniss.entadsl.com>
Date: Wed, 12 Sep 2007 17:07:41 +0100
From: Andy Furniss <lists@...yfurniss.entadsl.com>
To: jdb@...x.dk
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
Patrick McHardy <kaber@...sh.net>,
"David S. Miller" <davem@...emloft.net>,
Stephen Hemminger <shemminger@...ux-foundation.org>
Subject: Re: [PATCH 4/6] [IPROUTE2]: Overhead calculation is now done in the
kernel
Jesper Dangaard Brouer wrote:
> commit 07a74a2613440fc1a68d0faa7235ed7027532d78
> Author: Jesper Dangaard Brouer <hawk@...x.dk>
> Date: Tue Sep 11 16:59:58 2007 +0200
>
> [IPROUTE2]: Overhead calculation is now done in the kernel.
>
> The only current user is HTB. HTB overhead argument is now passed on
> to the kernel (in the struct tc_ratespec). Also correct the data
> types.
Thanks for getting this in.
It would be cool if mpu/overhead could be set per class > 255 and they
would affect the way htb shares bandwidth.
I could be wrong but it doesn't look like this will change current
behavior.Perhaps just allowing mpu/overhead > 255 for now, so that htb
sharing could be fixed up in the future?
The use would be for ingress shaping, you could set a big mpu for an
interactive class and it would cause bulk classes to get way less
bandwidth than otherwise, so you wouldn't permanently have to sacrifice
so much bandwidth on a slow link for latency - just when you needed to.
It could also, with the aid of netfilter connbytes, be used to preempt
the remote buffer filling when new bulk flows start.
One more thing, IIRC Devik acked your/Russels patch to change the
HYSTERESIS define to 0 - any chance of resubmitting?
Thanks
Andy.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists