lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 12 Sep 2007 15:16:43 -0700
From:	Andrew Morton <>
To:	Auke Kok <>
Subject: Re: [PATCH] [-MM, FIX] ixgbe: incorporate napi_struct changes from

On Wed, 12 Sep 2007 11:13:07 -0700
Auke Kok <> wrote:

> This incorporates the new napi_struct changes into ixgbe.

I get a reject storm.

> --- a/drivers/net/ixgbe/ixgbe_main.c
> +++ b/drivers/net/ixgbe/ixgbe_main.c
> @@ -557,14 +557,15 @@ static irqreturn_t ixgbe_msix_clean_rx(int irq, void *data)
>  	struct ixgbe_adapter *adapter = rxr->adapter;
>  	IXGBE_WRITE_REG(&adapter->hw, IXGBE_EIMC, rxr->eims_value);
> -	netif_rx_schedule(adapter->netdev);
> +	netif_rx_schedule(adapter->netdev, &adapter->napi);
>  	return IRQ_HANDLED;
>  }

For example, my copy of ixgbe_msix_clean_rx(), from
git:// is:

static irqreturn_t ixgbe_msix_clean_rx(int irq, void *data)
	struct ixgbe_ring *rxr = data;
	struct ixgbe_adapter *adapter = rxr->adapter;

	int i;

	for (i = 0; i < IXGBE_MAX_INTR; i++)
		if (unlikely(!ixgbe_clean_rx_irq(adapter, rxr)))
	IXGBE_WRITE_REG(&adapter->hw, IXGBE_EIMC, rxr->eims_value);
	return IRQ_HANDLED;

which is quite different from the function whcih you're altering here?
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists