netdev - dscc4.c tests for "#ifndef MODULE" even though it must be modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 12 Sep 2007 09:25:04 -0400 (EDT)
From:	"Robert P. J. Day" <rpjday@...dspring.com>
To:	netdev@...r.kernel.org
cc:	romieu@...zoreil.com
Subject: dscc4.c tests for "#ifndef MODULE" even though it must be modular

  from drivers/net/wan/dscc4.c:

=====
#ifndef MODULE
static int __init dscc4_setup(char *str)
{
        int *args[] = { &debug, &quartz, NULL }, **p = args;

        while (*p && (get_option(&str, *p) == 2))
                p++;
        return 1;
}

__setup("dscc4.setup=", dscc4_setup);
#endif
=====

  but from drivers/net/wan/Kconfig:

...
config DSCC4
        tristate "Etinc PCISYNC serial board support"
        depends on HDLC && PCI && m
...

  if i read this correctly, doesn't the depends on of "&& m" mean that
that Kconfig selection can be *at most* modular, so that that
preprocessor conditional can never be satisfied?  a quick test under
"make menuconfig" seems to confirm that.

  besides, the kernel parm being defined in that call to __setup()
really violates the spirit of defining kernel parms. :-)

rday
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://crashcourse.ca
========================================================================
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html